Add Recovery section in the new user settings Encryption tab
#28673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/encryption-tab
branch
3 times, most recently
from
7ee9a42 to
a90f51f
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
a90f51f to
b3dc812
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
b3dc812 to
98d86e0
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
98d86e0 to
2710462
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
2710462 to
5e31204
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
5e31204 to
54ede8b
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
54ede8b to
1811aa6
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
5 times, most recently
from
97b9f95 to
9aecfcc
Compare
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
cbf06fd to
e5dea48
Compare
richvdh
reviewed
Jan 13, 2025
src/components/views/settings/tabs/user/EncryptionUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
33
to
36
| * - `save_key_setup_flow`: The user is asked to save the new recovery key during the setup flow. | ||
| * - `save_key_change_flow`: The user is asked to save the new recovery key during the change key flow. | ||
| * - `confirm`: The user is asked to confirm the new recovery key. | ||
| * - `confirm_key_setup_flow`: The user is asked to confirm the new recovery key during the set up flow. | ||
| * - `confirm_key_change_flow`: The user is asked to confirm the new recovery key during the change key flow. |
There was a problem hiding this comment.
I have to say, I wonder if it wouldn't be simpler to just have three states (inform_user, save_key, confirm_key) and distinguish between the two flows by looking at the userHasRecoveryKey prop.
On the other hand, we should probably just get on and land this rather than messing with it forever. A thought for the future though.
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
cee03f0 to
bef3165
Compare
richvdh
reviewed
Jan 15, 2025
| @@ -21,14 +21,17 @@ import { SettingsSubheader } from "../SettingsSubheader"; | |||
| * - `loading`: We are checking the recovery key and the secrets. | |||
| * - `missing_recovery_key`: The user has no recovery key. | |||
| * - `secrets_not_cached`: The user has a backup but the secrets are not cached. | |||
| * This shouldn't happen but we have seen cases where the secrets gossiping failed or shared partial secrets when verified with another device. | |||
| * - `good`: The user has a backup and the secrets are cached. | |||
| * This can happen if we verified another device and secret-gossiping failed, or the other device itself lacked the secrets. | |||
There was a problem hiding this comment.
It's worth noting that this indentation is lost if/when the tsdoc is rendered to HTML, and is inconsistent with our style elsewhere.
But, not a big problem. Something to consider for the future.
src/components/views/settings/tabs/user/EncryptionUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
7ae6a78 to
ae163d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.First of all, I'm sorry for the size of the PR.
Task #26468
Figma design
Add a new encryption tab with a new recovery section.
Implemented
The encryption tab has the following behaviour:
The recovery section has the following behaviour:
Not implemented
This PR DON'T (because the PR is already massive and theses tasks should be done in other PRs):